Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rep cost to unexpected requests in statement distribution (peer rate limiting) #4356

Open
Overkillus opened this issue May 2, 2024 · 0 comments
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@Overkillus
Copy link
Contributor

Overkillus commented May 2, 2024

Issue postponed until most nodes update with the statement distribution rate limiting in #3444.

With the merge of #3444 we added peer limiting for statement distribution request response protocol. Nodes that already requested something from us should refrain from further requests until the first one finishes. For even better DoS prevention there could be a reputation punishment on the receiving side when encountering the unexpected request. While easy to do this was not added yet because older nodes are expected to continue sending those unexpected requests to newer nodes which might cause network fragmentation. Once a sufficient number of nodes update rep cost needs to be added which should fully close any relevant issues.

@Overkillus Overkillus added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants
@Overkillus and others