Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Implement: Availability Store #1240

Closed
rphmeier opened this issue Jun 10, 2020 · 4 comments
Closed

Implement: Availability Store #1240

rphmeier opened this issue Jun 10, 2020 · 4 comments
Assignees
Labels
S1-implement PR/Issue is in the implementation stage
Milestone

Comments

@rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added this to the Rockville milestone Jun 10, 2020
@rphmeier rphmeier added the S1-implement PR/Issue is in the implementation stage label Jun 10, 2020
@rphmeier
Copy link
Contributor Author

rphmeier commented Jun 18, 2020

The guide goes into detail on pruning and pruning constraints. We shouldn't need to implement the pruning stuff at first. Most important is just that the necessary data is stored and queryable.

@montekki What's described in the guide is pretty different from the API in the existing av_store crate. Do you think it'll be possible to port over, or should it be rewritten alongside?

@montekki
Copy link
Contributor

I don't think that porting is worth the effort, I say rewrite

@montekki montekki self-assigned this Jun 18, 2020
@rphmeier
Copy link
Contributor Author

rphmeier commented Jul 8, 2020

https://github.com/paritytech/polkadot/pull/1312/files#r451847813 - The store should also support storing full PoVs of things that we've validated, and should be able to answer all QueryChunk messages out of them. The pruning rules for stored chunks and stored PoVs are different and this is described in the guide already.

Ideally it can cache the erasure-codings so that multiple subsequent QueryChunk messages don't cause erasure coding to happen over and over again. Either that or there should be as QueryAllChunks message.

Also, StorePoV should accept an optional parameter with our own validator index, which will cause it to act sometihng like a StoreChunk message as well (with the same pruning rules as PoVs, unless the candidate is backed)

@montekki
Copy link
Contributor

Implemeted in #1404 . Pruning implementation is moved to #1488

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S1-implement PR/Issue is in the implementation stage
Projects
None yet
Development

No branches or pull requests

2 participants