Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update dispute participation on active leaves update #5875

Closed
eskimor opened this issue Aug 12, 2022 · 2 comments · Fixed by #6303
Closed

Update dispute participation on active leaves update #5875

eskimor opened this issue Aug 12, 2022 · 2 comments · Fixed by #6303
Assignees
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@eskimor
Copy link
Member

eskimor commented Aug 12, 2022

As described in the guide, it is perfectly possible for a node to learn about a dispute via dispute-distribution before seeing the candidate included on any chain. The node should however bump participation from best-effort to priority as soon as it learns about the inclusion.

We should also update spam slots accordingly - if we were not aware of the chain backing/including the candidate we might have bumped spam slots for the signing validator, that would also need to be reverted.

@ordian ordian added the T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. label Aug 16, 2022
@eskimor
Copy link
Member Author

eskimor commented Sep 13, 2022

With the change of the best-effort queue to be about backed candidates, something similar applies. We might not have seen (because severely out of sync) a block backing a candidate, while already receiving dispute votes. We would not participate in that case, but we should do so after the fact once we learn about the backing block.

@BradleyOlson64 BradleyOlson64 self-assigned this Sep 20, 2022
@BradleyOlson64
Copy link
Contributor

Leaning towards not increasing spam slots for backed candidates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants