Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[ci]: check-transaction-versions job doesn't work the git fetch origin release is wrong #6422

Closed
niklasad1 opened this issue Dec 12, 2022 · 5 comments · Fixed by #6509
Closed

Comments

@niklasad1
Copy link
Member

niklasad1 commented Dec 12, 2022

The check-transaction-versions is trying to fetch origin release which doesn't exist, so that has probably never worked.
https://github.com/paritytech/polkadot/blob/master/scripts/ci/gitlab/pipeline/build.yml#L56 is the cause of that.

See failed job here

It should most likely find release-v<some version> or the latest tag.

//cc @paritytech/ci

@alvicsam
Copy link
Contributor

Hm, it's strange. It worked previously https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2143528

@coderobe
Copy link
Contributor

Hm, it's strange. It worked previously https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2143528

that output is wrong too, though. best just allow-failure: true for the time being as it's not working correctly and breaking companion merges and such. we double-check transaction version when releasing anyway.

@niklasad1
Copy link
Member Author

Hm, it's strange. It worked previously https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2143528

all right, the branch release has probably been deleted recently :)

@alvicsam
Copy link
Contributor

we double-check transaction version when releasing anyway.

should we have this job in the pipeline then?

@bkchr
Copy link
Member

bkchr commented Jan 5, 2023

The check is failing again. If we don't need the check, please remove it @alvicsam

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants