Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime-cli: remove DB operations in async code #14066

Closed
liamaharon opened this issue May 3, 2023 · 2 comments
Closed

try-runtime-cli: remove DB operations in async code #14066

liamaharon opened this issue May 3, 2023 · 2 comments
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-runtime This PR/Issue is related to the topic “runtime”. U4-some_day_maybe Issue might be worth doing eventually. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@liamaharon
Copy link
Contributor 

          you don't have to do it in this PR but worth investing whether it makes things faster or not.

Ideally, we shouldn't do any DB operations in async code it might fuckup the async scheduler in tokio

Originally posted by @niklasad1 in #14057 (comment)
@liamaharon liamaharon assigned liamaharon and unassigned liamaharon May 3, 2023
@liamaharon liamaharon added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. U4-some_day_maybe Issue might be worth doing eventually. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. labels May 3, 2023
@ggwpez
Copy link
Member

ggwpez commented May 3, 2023 •
edited
Loading

Just as note: optimizing in this case is much lower prio than stability and good testing.
Formerly the try-runtime CLI would take 2hrs, so having it run in 2-5 minutes is already a huge improvement.
I would leave any further optimization for after the stabilization phase.

@liamaharon liamaharon changed the title try-runtime: remove DB operations in async code try-runtime-cli: remove DB operations in async code May 4, 2023
@juangirini juangirini added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 7, 2023
@liamaharon
Copy link
Contributor Author

Moved to paritytech/try-runtime-cli#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-runtime This PR/Issue is related to the topic “runtime”. U4-some_day_maybe Issue might be worth doing eventually. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juangirini @ggwpez @liamaharon