Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Different chain networks should not route each other's p2p node information to each other. #1913

Closed
gguoss opened this issue Mar 4, 2019 · 5 comments
Labels
J0-enhancement An additional feature request.
Milestone

Comments

@gguoss
Copy link
Contributor

gguoss commented Mar 4, 2019

2019-03-04 15:23:44.419 INFO Banned PeerId(QmdU82FC39tj6YUFsie2cC3LLjqWEqA6C7N5piWb8XTjWX) (#5, Dialer { address: "/ip4/47.96.97.52/tcp/31127" }, None).

There are some different p2p information in network/node.json.

@bkchr
Copy link
Member

bkchr commented Mar 4, 2019

CC @tomaka

@tomaka
Copy link
Contributor

tomaka commented Mar 4, 2019

Right now the network is differentiated based on the protocol_id in the chain spec:

pub protocol_id: Option<String>,

Unfortunately, if you don't specify this value, it will default to sub. All the chains that use sub will conflict with each other and get these "banned peer" messages.

Later I'd like to try switch to a different discovery mechanism that allows knowing which chain a node belongs to when discovering it.
cc libp2p/rust-libp2p#942

@gavofyork gavofyork added this to the 1.x series milestone Mar 10, 2019
@gavofyork gavofyork added the J0-enhancement An additional feature request. label Mar 10, 2019
@tomaka
Copy link
Contributor

tomaka commented Apr 14, 2020

Progress report: #5045 is the first step towards fixing this.
We need a transition period during which nodes support both the old Kademlia and the one-DHT-per-chain. Then later we can finish this by removing the old Kademlia.

@tomaka
Copy link
Contributor

tomaka commented May 15, 2020

#5993 removed the old Kademlia.
The last step is #5825

@tomaka
Copy link
Contributor

tomaka commented Jul 29, 2020

Fixed in #6549

@tomaka tomaka closed this as completed Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

4 participants