Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

ReapedAcccount event is spammed when multiple transactions are placed in the same block #4402

Closed
shawntabrizi opened this issue Dec 16, 2019 · 2 comments · Fixed by #4628
Closed
Assignees
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Milestone

Comments

@shawntabrizi
Copy link
Member

Take a look at Kusama CC-3 Block here:
https://polkadot.js.org/apps/#/explorer/query/0x3cf167740da9aac3559a95247cb015d2324fd259e9a12da570a8b782bca04909

In this block, a user submits multiple transactions which transfers their full balance. All but the first transaction failed (good).

However, you can see that the ReapedAccount event was emitted multiple times, when it should only really be emitted once here.

We should improve this.

@shawntabrizi shawntabrizi added this to the 2.1 milestone Dec 16, 2019
@shawntabrizi shawntabrizi self-assigned this Dec 16, 2019
@bkchr bkchr added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Dec 16, 2019
@dud1337
Copy link

dud1337 commented Jan 14, 2020

After discussion with @laboon, this issue appears to be related to a negative "Active Accounts" integer on https://polkascan.io/pre/kusama-cc3

undead_active

@shawntabrizi
Copy link
Member Author

@dud1337 indeed, that along with the fact that Kusama had zero fees for a while, so any account with zero nonce and zero value could submit a transaction and that would also trigger the ReapedAccount event.

Not sure if there is a good solution to this for situations where there are no fees.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants