Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change storage key arguments (and call arguments?) to being references #411

Closed
Tracked by #345
jsdw opened this issue Jan 27, 2022 · 1 comment · Fixed by #447
Closed
Tracked by #345

Change storage key arguments (and call arguments?) to being references #411

jsdw opened this issue Jan 27, 2022 · 1 comment · Fixed by #447
Labels
enhancement New feature or request good first issue Small, well scoped, simple; good for newcomers

Comments

@jsdw
Copy link
Collaborator

jsdw commented Jan 27, 2022

Currently we pass these by value:

84fe1a0

But we can see in an example of the generated code that we only need a reference ultimately:

pub async fn pending_swap(
    &self,
    _0: runtime_types::polkadot_parachain::primitives::Id,
    hash: ::core::option::Option<T::Hash>,
) -> ::core::result::Result<
    ::core::option::Option<
        runtime_types::polkadot_parachain::primitives::Id,
    >,
    ::subxt::BasicError,
> {
    let entry = PendingSwap(_0);
    self.client.storage().fetch(&entry, hash).await
}
@ascjones
Copy link
Contributor

💯 would be good to add this before we release.

@jsdw jsdw added the good first issue Small, well scoped, simple; good for newcomers label Jan 27, 2022
@jsdw jsdw mentioned this issue Feb 1, 2022
16 tasks
@lexnv lexnv mentioned this issue Feb 14, 2022
2 tasks
@lexnv lexnv closed this as completed in #447 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Small, well scoped, simple; good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants