Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic DispatchError::Module details #443

Closed
ascjones opened this issue Feb 9, 2022 · 1 comment · Fixed by #453
Closed

Dynamic DispatchError::Module details #443

ascjones opened this issue Feb 9, 2022 · 1 comment · Fixed by #453
Assignees

Comments

@ascjones
Copy link
Contributor

ascjones commented Feb 9, 2022

#394 removes the lookup for error details from metadata at runtime, instead using the static metadata.

This will only work if the configuration of the target runtime modules is identical to that of the compile time metadata. So for tools which target a single pallet that might be present across many versions of many chains (e.g. cargo-contract, or xcm-cli) then the error resolution might not work.

This was one of the original design goals for this library, and indeed the resolution of indices for constructing extrinsics and decoding events is still dynamic. So there should also be a similar mechanism for resolving runtime error details.

@jsdw
Copy link
Collaborator

jsdw commented Feb 9, 2022

I guess the best option is to reinstate the dynamic error information fetching code that was removed in that PR. We could then ponder either removing the statically generated stuff and tweaking the API to obtain details from the dynamic again, or keep both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants