-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Custom Asset Claimer #37
RFC: Custom Asset Claimer #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work specifying this new instruction! Left some comments but overall the addition seems solid. Thank you for contributing 😁
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/xcm-rfc-dropped-assets-claimers/3176/1 |
I suspect that being able to split up assets arbitrarily and allow for numerous claimants is probably going to be difficult to guarantee economic security. I think something like |
I agree with Gavin's comment above. Indeed, having just one claimer for all the dropped assets should be enough to rescue them conveniently. Also, this instruction will be much easier to implement. If there is a need for complex claiming logic, a smart contract could be set as a claimer. The RFC is modified accordingly. |
@franciscoaguirre, the RFC is modified. Could you take a look, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification 🚀
Starting the FCP (Final Comment Period), it will last 10 calendar days. After that, this RFC will be either accepted, rejected or explicitly postponed for a future time. |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/final-comment-period-for-two-xcm-rfcs/3516/1 |
The FCP for this RFC is over. The RFC has been accepted! The next steps would be to:
How does that sound @mrshiposha ? |
@franciscoaguirre sounds great! |
@franciscoaguirre I updated the RFC info:
|
@mrshiposha |
@franciscoaguirre Sure! Here it is: #41 |
Summary
The proposed change provides a way to set a claimer to potentially dropped assets.
Currently, determining a claimer of dropped assets is implementation-specific, and there is no way to set a custom claimer.
The ability to set a custom claimer origin makes it easier to rescue the dropped assets, especially in the case of a reserve-based transfer.