-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to sync multiple collections and fix bugs #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
parkerbxyz
force-pushed
the
fix-self-healing
branch
from
April 5, 2024 04:45
fd8d54d
to
47b95fe
Compare
parkerbxyz
force-pushed
the
fix-self-healing
branch
from
April 5, 2024 05:25
47b95fe
to
44056a3
Compare
parkerbxyz
changed the title
Improve error handling and update Guru SDK
Improve error handling and update dependencies
Apr 5, 2024
parkerbxyz
force-pushed
the
fix-self-healing
branch
3 times, most recently
from
April 5, 2024 18:31
e3c719a
to
4147545
Compare
parkerbxyz
force-pushed
the
fix-self-healing
branch
from
April 11, 2024 00:15
22bb7ce
to
9fa7aa4
Compare
parkerbxyz
force-pushed
the
fix-self-healing
branch
from
April 11, 2024 00:21
9fa7aa4
to
a04ec73
Compare
parkerbxyz
changed the title
Improve error handling and update dependencies
feat: add ability to sync multiple collections
Apr 11, 2024
parkerbxyz
added a commit
that referenced
this pull request
Apr 11, 2024
* refactor: use `or` operator to simplify code * fix: do not attempt to delete nonexistent file * fix: set external_id to None if not found in metadata * fix(deps): update dependencies * fix: handle special characters in folder names * feat: add support for syncing multiple collections * fix: skip images with invalid extension * docs(README): update inputs and example workflows * fix: quote file path in API request URLs
parkerbxyz
added a commit
that referenced
this pull request
Apr 11, 2024
refactor: use `or` operator to simplify code fix: do not attempt to delete nonexistent file fix: set external_id to None if not found in metadata fix(deps): update dependencies fix: handle special characters in folder names feat: add support for syncing multiple collections fix: skip images with invalid extension docs(README): update inputs and example workflows fix: quote file path in API request URLs
parkerbxyz
changed the title
feat: add ability to sync multiple collections
Add ability to sync multiple collections
Apr 11, 2024
parkerbxyz
added a commit
that referenced
this pull request
Apr 11, 2024
refactor: use `or` operator to simplify code Source-Link: ba77df7 fix: do not attempt to delete nonexistent file Source-Link: fe5df41 fix: set external_id to None if not found in metadata Source-Link: 42e1c3c fix(deps): update dependencies Source-Link: 80da4b3 fix: handle special characters in folder names Source-Link: 44056a3 feat: add support for syncing multiple collections Source-Link: fecabfe fix: skip images with invalid extension Source-Link: 9b5c288 docs(README): update inputs and example workflows Source-Link: 0ba2633 fix: quote file path in API request URLs Source-Link: a04ec73
parkerbxyz
added a commit
that referenced
this pull request
Apr 11, 2024
refactor: use `or` operator to simplify code fix: do not attempt to delete nonexistent file fix: set external_id to None if not found in metadata fix(deps): update dependencies fix: handle special characters in folder names feat: add support for syncing multiple collections fix: skip images with invalid extension docs(README): update inputs and example workflows fix: quote file path in API request URLs
parkerbxyz
changed the title
Add ability to sync multiple collections
Add ability to sync multiple collections and fix bugs
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes in the
README.md
,action.yml
,github_publisher.py
, andPipfile
files. The primary changes are related to the ability to sync multiple Guru collections simultaneously, changes in the naming convention of inputs, and modifications to thegithub_publisher.py
script for better error handling and improved code efficiency.Improvements to file path handling:
github_publisher.py
: Several methods have been updated to use thequote
function fromurllib.parse
when creating URLs for GitHub API requests, which ensures special characters in file paths are correctly encoded. Therstrip
method calls on collection and folder names have been replaced withstrip
to remove leading and trailing whitespace. [1] [2] [3] [4] [5] [6]Updates to handling multiple Guru collections:
README.md
: The documentation has been updated to reflect changes in how multiple Guru collections are handled. Instead of using a matrix strategy, a comma-separated list of Collection IDs is now provided to theguru-collection-ids
input. [1] [2]github_publisher.py
: The script now supports multiple Guru collections by accepting a comma-separated list of Collection IDs from theGURU_COLLECTION_IDS
environment variable.Deprecation of input parameters:
action.yml
: Theguru_collection_id
andcollection_directory_path
input parameters have been deprecated and replaced withguru-collection-ids
andcollection-directory-path
, respectively. Theruns
section has been updated to support both the new and deprecated parameters. [1] [2]Other changes:
Pipfile
: The reference for theguru
package has been updated.README.md
: The note has been changed to a tip.github_publisher.py
: Several other minor changes have been made, including better error handling when a SHA is not found in the repository, and better handling of images without an extension or filename inconvert_card_content
. [1] [2] [3]