Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOAWAY errors #140

Open
maxmijn opened this issue Mar 14, 2024 · 7 comments
Open

GOAWAY errors #140

maxmijn opened this issue Mar 14, 2024 · 7 comments

Comments

@maxmijn
Copy link

maxmijn commented Mar 14, 2024

We have consistently been getting this error on about 1 out of 100 notifications we sent. Any idea how we can fix this?

apn write failed: New streams cannot be created after receiving a GOAWAY
Copy link

Thanks for opening this issue!

@mtrezza
Copy link
Member

mtrezza commented Mar 14, 2024

Looks like a rate limit, or maybe the stream is just closed.

@maxmijn
Copy link
Author

maxmijn commented Mar 15, 2024

Thanks for looking into this!

If I look at the error codes that APNS should be returning I would expect some more information if running into a rate limit. I can't really find anything else about this error apart from some fix in an unmaintained version of this project. Do you know any other way I can debug why this is happening and perhaps prevent this in the future?

@v-xuesjiang
Copy link

image
I send notifications every day and consistently encounter this error. To prevent redundancy, I refrain from retrying. Could you please help me understand why this is happening and suggest ways to reduce the error rate?

@mtrezza
Copy link
Member

mtrezza commented Mar 21, 2024

If anyone wants to open a PR here with the fixes, then we can merge.

@maxmijn
Copy link
Author

maxmijn commented Mar 21, 2024

I believe those fixes are already implemented in this library.

@mtrezza
Copy link
Member

mtrezza commented Mar 21, 2024

Got it, in that case it would be great if someone who is experiencing this issue could investigate some more, possibly manually add a log line to where this issue occurs so we can get more info in case the apn library swallows some of the error information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants