fix: Incorrect field name event instead of events in Live Activity push notification payload

[dplewis]

Per the documentation https://developer.apple.com/documentation/activitykit/updating-and-ending-your-live-activity-with-activitykit-push-notifications

event should be events

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9fa197f) 93.53% compared to head (f508a0d) 93.53%.

❗ Current head f508a0d differs from pull request most recent head c240d75. Consider uploading reports for the commit c240d75 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          23       23           
  Lines         588      588           
=======================================
  Hits          550      550           
  Misses         38       38           

Impacted Files	Coverage Δ
lib/notification/index.js	100.00% <ø> (ø)
lib/notification/apsProperties.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dplewis]

@mtrezza This is ready for review

[parseplatformorg]

🎉 This change has been released in version 5.2.3

[kurtguenther]

@dplewis @mtrezza this change seems wrong from the Apple documentation that I see on your referenced page.

  "aps": {
        "timestamp": 1685952000,
        "event": "update",
        ...

It clearly says that we should use event and NOT events.

Using my own project, I am able to send live activity updates using version 5.2.2 but in 5.2.3 (which contains the event => events PR here) breaks pushing live activity updates.

When I review the Console log I see this error Incoming message does not contain an event type which makes sense since iOS is looking for the events rather than events field.

Should we revert this? Or am I way off course here.

Thanks.

[dplewis]

Apple must have updated the API. events type did look weird to me.

Can you open a new issue?

[kurtguenther]

Will do! I'm going to push up a PR that also includes the dismissal-date field which is used when a live activity is ended.

[parseplatformorg]

🎉 This change has been released in version 6.0.2