Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no warning dialog before deleting config parameter #1323

Closed
mtrezza opened this issue Oct 2, 2019 · 9 comments
Closed

no warning dialog before deleting config parameter #1323

mtrezza opened this issue Oct 2, 2019 · 9 comments
Labels
type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Oct 2, 2019

Issue

When deleting a Parse Config parameter by clicking on the trash icon image the parameter is deleted without showing a warning dialog.

As it can happen that the trash icon is clicked by mistake, one wouldn't easily see which parameter has been deleted in a long list of parameters. There is also no built-in way to easily restore a key and value that has been deleted by mistake.

Suggested solution

Add a warning dialog for the user to confirm the deletion. Similar to the warning dialog when deleting a row.

image

The warning dialog should at least include the parameter's key name.

Environment Setup

  • Parse Dashboard 2.0.3

Steps to reproduce

--

Logs/Trace

--

@davimacedo
Copy link
Member

I like the idea. Would you be willed to add this one?

@davimacedo davimacedo added the type:feature New feature or improvement of existing feature label Oct 4, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Oct 4, 2019

At the moment not, but maybe someone wants to pick it up. Seems to be a good first PR.

@stale
Copy link

stale bot commented Nov 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:wont-fix Won’t be fixed with a clearly stated reason label Nov 18, 2019
@stale stale bot closed this as completed Nov 25, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Jan 13, 2020

@davimacedo can you reopen please, PR in the works

@davimacedo
Copy link
Member

Sure!

@davimacedo davimacedo reopened this Jan 14, 2020
@stale stale bot removed the state:wont-fix Won’t be fixed with a clearly stated reason label Jan 14, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Feb 22, 2020

PR merged

@mtrezza mtrezza closed this as completed Feb 22, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Apr 7, 2020

@davimacedo When can we expect the next release? I would like to see this feature added, after 6 months.

@TomWFox
Copy link
Contributor

TomWFox commented Apr 7, 2020

Yes we should definitely do a release, if no one beats me to it I'll do the release notes tomorrow!

@davimacedo
Copy link
Member

Go for it @TomWFox . We have a lot of good stuff here ready to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants