From ac608961eab4fc0024167581de5e1e91817b27fc Mon Sep 17 00:00:00 2001 From: Corey's iMac Date: Fri, 23 Dec 2022 00:00:04 -0500 Subject: [PATCH 1/2] feat: improve Dockerfile to conform to best practices --- Dockerfile | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index afb3bfe756..e695791629 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,10 +1,9 @@ ############################################################ # Build stage ############################################################ -FROM node:lts-alpine AS base +FROM node:lts-alpine AS build -RUN apk update; \ - apk add git; +RUN apk --no-cache add git WORKDIR /src # Copy package.json first to benefit from layer caching @@ -32,11 +31,11 @@ FROM node:lts-alpine AS release WORKDIR /src # Copy production node_modules -COPY --from=base /src/prod_node_modules /src/node_modules -COPY --from=base /src/package*.json /src/ +COPY --from=build /src/prod_node_modules /src/node_modules +COPY --from=build /src/package*.json /src/ # Copy compiled src dirs -COPY --from=base /src/Parse-Dashboard/ /src/Parse-Dashboard/ +COPY --from=build /src/Parse-Dashboard/ /src/Parse-Dashboard/ USER node From dfd5aa979f62d6f3bb5dc6c341d98409416fdf53 Mon Sep 17 00:00:00 2001 From: Corey's iMac Date: Fri, 23 Dec 2022 00:50:08 -0500 Subject: [PATCH 2/2] fix production warning in docker build --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index e695791629..ac0bf826df 100644 --- a/Dockerfile +++ b/Dockerfile @@ -10,7 +10,7 @@ WORKDIR /src COPY package*.json ./ # Install without scripts otherwise webpack will fail -RUN npm ci --production --ignore-scripts +RUN npm ci --omit=dev --ignore-scripts # Copy production node_modules aside for later RUN cp -R node_modules prod_node_modules