Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation DEPPS1: Native MongoDB syntax in aggregation pipeline #8268

Closed
3 tasks done
Tracked by #8225
mtrezza opened this issue Nov 2, 2022 · 7 comments · Fixed by #8362
Closed
3 tasks done
Tracked by #8225

Remove deprecation DEPPS1: Native MongoDB syntax in aggregation pipeline #8268

mtrezza opened this issue Nov 2, 2022 · 7 comments · Fixed by #8362
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Nov 2, 2022

New Feature / Enhancement Checklist

Current Limitation

Deprecation to be removed in Parse Sever 6:

  • DEPPS1: Native MongoDB syntax in aggregation pipeline

Feature / Enhancement Description

Remove deprecation, see list.

Example Use Case

n/a

Alternatives / Workarounds

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 2, 2022

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added type:feature New feature or improvement of existing feature block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Nov 2, 2022
@mtrezza mtrezza mentioned this issue Nov 2, 2022
31 tasks
@SebC99
Copy link
Contributor

SebC99 commented Nov 24, 2022

Hello @mtrezza
Do you plan to also remove all the type conversions in the pipeline? (the _parseAggregateArgs method basically).
It's a real mess to write aggregation with Parse, as some fields are converted and others are not, some are wrongly converted, some are removed, etc.
Dates fields are very messy too.

@mtrezza
Copy link
Member Author

mtrezza commented Nov 25, 2022

This issue is just removing the deprecation; see #7338 and #7339 for the full scope of the deprecation.

I think you are referring to #7868. That's a separate issue and currently without an ETA. There is an existing PR #8172, but it's still WIP.

@SebC99
Copy link
Contributor

SebC99 commented Nov 25, 2022

True, thanks.
Except #7868 should be broader as there are server crash issues but also wrong results ones as you the pipeline is modified under the hood. I'll try to look into #8172 .

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.19

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 5, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
3 participants