Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sage calss of OpenMP clause #147

Open
ouankou opened this issue Jan 5, 2023 · 0 comments
Open

Change the sage calss of OpenMP clause #147

ouankou opened this issue Jan 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ouankou
Copy link
Contributor

ouankou commented Jan 5, 2023

Currently, IR for the OpenMP clause is SgOmpClause, which is extended from SgLocatedNodeSupport. At the same level as SgLocatedNodeSupport, there is SgExpression. It may be more suitable for the OpenMP clause because, as part of the directive, each portion, in this case, the clause, could be considered as an expression. Like any expression, it's a tree with some child nodes.

To make the change, we first need to update ROSETTA and let SgOmpClause extend from SgExpression. It should be enough, but we should double-check if anything is broken elsewhere. For now, this is not a high priority, we can leave it as-is.

@ouankou ouankou added the enhancement New feature or request label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant