Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes all logic from interfaces #13

Merged
merged 2 commits into from
Dec 2, 2018

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 2, 2018

Implementer have to implement them anyhow

Implemented *have* to implement them anyhow
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   54.88%   54.98%   +0.09%     
==========================================
  Files          27       24       -3     
  Lines        1135     1133       -2     
==========================================
  Hits          623      623              
+ Misses        512      510       -2
Impacted Files Coverage Δ
lib/src/collection/map.dart 69.04% <0%> (-3.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cd869...d7df95b. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #13      +/-   ##
=========================================
+ Coverage   54.88%   55.6%   +0.71%     
=========================================
  Files          27      24       -3     
  Lines        1135    1133       -2     
=========================================
+ Hits          623     630       +7     
+ Misses        512     503       -9
Impacted Files Coverage Δ
lib/src/collection/map.dart 73.8% <100%> (+1.3%) ⬆️
lib/src/extension/iterable_extension_mixin.dart 47.61% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cd869...e32eaf5. Read the comment docs.

@passsy passsy merged commit 2ebea61 into master Dec 2, 2018
@passsy passsy deleted the feature/remove_code_from_interfaces branch December 2, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant