Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non compiling APIs due to a dart-lang bug #46

Merged
merged 2 commits into from
Dec 30, 2018

Conversation

passsy
Copy link
Owner

@passsy passsy commented Dec 30, 2018

Bug dart-lang/sdk#35518 prevents calls from external classes to those methods. the generic bound type is not correctly passed to the method resulting in a wrong inferred argument bounds violation.

Removed extensions:

  • KIterable<T>.associateWithTo
  • Kiterable<T>.filterTo
  • KIterable<T>.filterIndexedTo
  • KIterable<T>.filterNotTo
  • KIterable<T>.filterNotNullTo
  • KIterable<T>.groupByTo
  • KMap<T>.mapKeysTo
  • KMap<T>.mapValuesTo

Other ..To extensions like KIterable<T>.flatMapTo aren't affected. They don't have a generic type of the mixin in their generic type bounds.

Bug dart-lang/sdk#35518 prevents calls from external classes to those methods to not pass the generic bound type correctly resulting in a wrong inferred argument bounds violation
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #46 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #46     +/-   ##
=========================================
- Coverage   94.19%   93.99%   -0.2%     
=========================================
  Files          25       25             
  Lines        1515     1515             
=========================================
- Hits         1427     1424      -3     
- Misses         88       91      +3
Impacted Files Coverage Δ
lib/src/extension/map_extensions_mixin.dart 100% <ø> (ø) ⬆️
lib/src/extension/iterable_extension_mixin.dart 96.07% <ø> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c9df3...3543e07. Read the comment docs.

@passsy passsy merged commit b7b7c07 into master Dec 30, 2018
@passsy passsy deleted the feature/remove_non_compiling_apis branch December 30, 2018 19:49
@passsy passsy mentioned this pull request Dec 31, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant