Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

didScrollToSegment not being called on programatic segment change #325

Closed
gbateman opened this issue Feb 27, 2017 · 6 comments
Closed

didScrollToSegment not being called on programatic segment change #325

gbateman opened this issue Feb 27, 2017 · 6 comments

Comments

@gbateman
Copy link

gbateman commented Feb 27, 2017

Calling this function:
self.calendarView.scrollToSegment(.previous, triggerScrollToDateDelegate: true, animateScroll: true)

On a button action, but the

func calendar(_ calendar: JTAppleCalendarView, didScrollToDateSegmentWith visibleDates: DateSegmentInfo) {

delegate method is not getting called in 6.1.3, so we reverted to 6.1.1 where it is currently working. Not sure if this issue exists on 6.1.2.

Hope this helps someone or can be resolved

@patchthecode
Copy link
Owner

looking into this immediately.
Could be a newly introduced bug.

@patchthecode
Copy link
Owner

The error has been fixed on master branch.
If you wish to test the latest code with the fix, the click here

@gbateman
Copy link
Author

Yup, it seems to be working now with the latest code. Thanks for responding and fixing this so quickly!

@patchthecode
Copy link
Owner

Cool. Im the only tester, so if you find any other issue, then let me know. There should be no errors with this library, so I plan to fix them quickly if found. Keep me posted if you find new ones. Cheers 🍻

@Dean151
Copy link
Contributor

Dean151 commented Feb 28, 2017

I just converted my code to Swift 3 and updated JTAppleCalendar to the latest version, and I was about to open this issue if it did not exists !
Cool for the fix. Can't wait for 6.1.4 release then !

@patchthecode
Copy link
Owner

released 6.1.4
closing this issue.

If any new bugs found then let me know. I'll fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants