Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SNAPSHOT version checking logic for in script. #12

Closed
shinmyung0 opened this issue Oct 3, 2017 · 1 comment
Closed

Incorrect SNAPSHOT version checking logic for in script. #12

shinmyung0 opened this issue Oct 3, 2017 · 1 comment

Comments

@shinmyung0
Copy link

shinmyung0 commented Oct 3, 2017

I noticed that the implicit get after a put for my snapshot artifacts were breaking. I did some digging and the reason was that the implicit get step was looking for the snapshot version artifacts from the release_url. This is due to a typo in the in script for checking whether a version is a snapshot version.

in script uses an &&
https://github.com/patrickcrocker/maven-resource/blob/master/assets/in#L89

out script uses an || which is the correct behavior.
https://github.com/patrickcrocker/maven-resource/blob/master/assets/out#L106

I fixed my pipeline scripts to use 1.3.2 instead of latest for now. Thanks again for your great work!

@patrickcrocker
Copy link
Member

This is now fixed and the 1.3.3 release has been yanked. Thanks!

See: https://github.com/Pivotal-Field-Engineering/maven-resource/releases/tag/v1.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants