You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Setting the setpoint (thrust and torque) on SimpleThruster ignores the thrust if it does not pass the check for upper limit > lower limit. By default the limits are (1, -1), so by default setSetpoint ignores input thrust.
To Reproduce
Steps to reproduce the behavior:
Set the setpoint on a SimpleThruster without setting the limits first, the call getThrust() and the thrust will have not changed.
Expected behavior
Setting the thrust setpoint should work when limits are not set.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Smartphone (please complete the following information):
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Additional context
You can see this via code inspection here:
Describe the bug
Setting the setpoint (thrust and torque) on
SimpleThruster
ignores the thrust if it does not pass the check for upper limit > lower limit. By default the limits are (1, -1), so by defaultsetSetpoint
ignores input thrust.To Reproduce
Steps to reproduce the behavior:
Set the setpoint on a
SimpleThruster
without setting the limits first, the callgetThrust()
and the thrust will have not changed.Expected behavior
Setting the thrust setpoint should work when limits are not set.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
You can see this via code inspection here:
stonefish/Library/src/actuators/SimpleThruster.cpp
Lines 61 to 75 in ec1ee1f
The text was updated successfully, but these errors were encountered: