Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) #967

Seanom · 2018-10-31T09:41:33Z

I am using Pattern Lab Node v3.0.0.0-beta.1 on Mac High Sirerra, with Node v10.11.0, using a Vanilla Edition.

There is an issue when using Yarn on unix based systems, I'm using a Mac but I've seen people using Ubuntu experience the same problem and I've not seen it jotted down yet here.

When running 'yarn' files are installed using the encoded line breaks, it appears that NPM changes this to the system specific version. However if the file is encoded with CRLF then this results in the following message

env: node\r: No such file or directory

This does not occur on windows, and only appears if you install using yarn to get around this it's possible to install using npm install and then using yarn to run scripts

There is an issue about this over on the yarn github page yarnpkg/yarn#5480
I've also spotted a couple of people in the pattern lab gitter.im channel.

Expected Behavior

Files are encoded using LF line separators

Actual Behavior

Many of the files are encoded using CRLF line separators, which results in the error when using yarn

env: node\r: No such file or directory

Steps to Reproduce

Reproduced on a mac High Sierra 10.13.6

Ensure the package.json exists (I used the following)

 {
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "pl:build": "patternlab build --config ./patternlab-config.json",
    "pl:help": "patternlab --help",
    "pl:install": "patternlab install --config ./patternlab-config.json",
    "pl:serve": "patternlab serve --config ./patternlab-config.json",
    "pl:version": "patternlab --version"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@pattern-lab/cli": "^0.0.1-beta.1",
    "@pattern-lab/core": "^3.0.0-beta.1",
    "@pattern-lab/engine-mustache": "^2.0.0-beta.0",
    "@pattern-lab/uikit-workshop": "^1.0.0-beta.0"
  }
 }

Run yarn (everything installs)
Run yarn pl:help

Observe the error message

yarn run v1.10.1
$ patternlab --help
env: node\r: No such file or directory
error Command failed with exit code 127.

It's also possible to run the following

npm init -y && npx @pattern-lab/cli -c patternlab init
Leave the directory as default
Install node version
Select None for the starter template
Once installed delete the node_modules folder
Run yarn
Run yarn pl:help
Observe, the error message as above

The text was updated successfully, but these errors were encountered:

DanielRuf · 2018-11-02T10:35:42Z

Same here, using latest version of Yarn stable and Node 10 LTS.

stale · 2019-01-01T17:45:23Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale · 2019-01-19T02:59:27Z

Issue closed after going stale. It can be re-opened if still relevant.

DanielRuf · 2019-01-19T08:45:48Z

I hate such bots like the stale bot.

jp-sauve · 2019-02-09T00:42:23Z

This is still relevant.

{
  "name": "patternlab",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "patternlab": "patternlab",
    "pl:build": "patternlab build --config ./patternlab-config.json",
    "pl:help": "patternlab --help",
    "pl:install": "patternlab install --config ./patternlab-config.json",
    "pl:serve": "patternlab serve --config ./patternlab-config.json",
    "pl:version": "patternlab --version"
  },
  "devDependencies": {
    "@pattern-lab/cli": "^0.0.1-beta.1"
  },
  "dependencies": {
    "@pattern-lab/cli": "^0.0.1-beta.1",
    "@pattern-lab/core": "^3.0.0-beta.1",
    "@pattern-lab/engine-mustache": "^2.0.0-beta.0",
    "@pattern-lab/uikit-workshop": "^1.0.0-beta.0",
    "starterkit-twig-drupal-demo": "pattern-lab/starterkit-twig-drupal-demo"
  }
}

and here's some log output for you. I'm using Linux.

1 verbose cli [ '/home/fathead/.nvm/versions/node/v10.5.0/bin/node',
1 verbose cli   '/home/fathead/.nvm/versions/node/v10.5.0/bin/npm',
1 verbose cli   'run',
1 verbose cli   'patternlab',
1 verbose cli   '--',
1 verbose cli   'serve' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prepatternlab', 'patternlab', 'postpatternlab' ]
5 info lifecycle [email protected]~prepatternlab: [email protected]
6 info lifecycle [email protected]~patternlab: [email protected]
7 verbose lifecycle [email protected]~patternlab: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]~patternlab: PATH: /home/fathead/.nvm/versions/node/v10.5.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/fathead/Workspace/patternlab/node_modules/.bin:/home/fathead/.yarn/bin:/home/fathead/.config/yarn/global/node_modules/.bin:/home/fathead/.nvm/versions/node/v10.5.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/home/fathead/bin:/home/fathead/.npm-packages/bin
9 verbose lifecycle [email protected]~patternlab: CWD: /home/fathead/Workspace/patternlab
10 silly lifecycle [email protected]~patternlab: Args: [ '-c', 'patternlab "serve"' ]
11 info lifecycle [email protected]~patternlab: Failed to exec patternlab script
12 verbose stack Error: [email protected] patternlab: `patternlab "serve"`
12 verbose stack spawn ENOENT
12 verbose stack     at ChildProcess.<anonymous> (/home/fathead/.nvm/versions/node/v10.5.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:48:18)
12 verbose stack     at ChildProcess.emit (events.js:182:13)
12 verbose stack     at maybeClose (internal/child_process.js:961:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)
13 verbose pkgid [email protected]
14 verbose cwd /home/fathead/Workspace/patternlab
15 verbose Linux 4.15.0-45-generic
16 verbose argv "/home/fathead/.nvm/versions/node/v10.5.0/bin/node" "/home/fathead/.nvm/versions/node/v10.5.0/bin/npm" "run" "patternlab" "--" "serve"
17 verbose node v10.5.0
18 verbose npm  v6.1.0
19 error file sh
20 error code ELIFECYCLE
21 error errno ENOENT
22 error syscall spawn
23 error [email protected] patternlab: `patternlab "serve"`

DanielRuf · 2019-02-09T05:57:35Z

This is still relevant.

Sure, this is why it was reopened ;-)

zachariab · 2019-03-27T00:58:08Z

Upgrading @pattern-lab/cli to 0.0.1-beta.2 resolved this issue for me. I'm not quite sure why, though.

I verified there are CRLF line separators in the file packages/cli/bin/patternlab.js at 0.0.1-beta.1 that are fixed in 0.0.1-beta.2. That's true using either yarn or npm, although npm changes the first line break to at LF preventing the "No such file or directory" error.

The mystery is I couldn't find a commit that would change the line ending in that file between beta.1 and beta.2. In any case, it's working for me now.

zachariab · 2019-03-29T04:02:32Z

My best guess is that this is related to the npm issue npm publish from Windows handles CRLF incorrectly

Is it possible that the releases prior to 0.0.1-beta.2 were published from a windows machine but newer ones from mac/unix? That would explain the CRLF I'm seeing in previous releases, which npm fixes but yarn does not.

stale · 2019-05-28T04:11:12Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

DanielRuf · 2019-05-28T04:17:22Z

Not stale, still relevant.

stale · 2019-07-27T04:34:05Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale · 2019-09-25T09:33:26Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

DanielRuf · 2019-09-25T11:04:42Z

Not stale.

stale · 2019-11-24T11:26:49Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale · 2019-12-24T11:56:18Z

Issue closed after going stale. It can be re-opened if still relevant.

bradjones1 · 2021-04-19T23:52:19Z

Not stale.

roman-sitewits · 2021-05-17T01:04:19Z

Still relevant!!!

Also here is the yarn bug:
yarnpkg/yarn#5480

theLine · 2021-09-21T07:11:03Z

I'm getting the same error on MacOS 11.6.
It seems that it doesn't matter whether I use yarn (1.22.11) or npm (6.14.13) with node v14.
The executable (node_modules/.bin/patternlab) still will get windows line-endings.

EDIT: I found a workaround. I've installed dos2unix-cli and added a postinstall hook in the package.json:

  "scripts": {
    "postinstall": "dos2unix node_modules/.bin/patternlab"
  },

stale · 2022-01-09T00:29:34Z

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

mfranzke · 2022-01-30T12:00:56Z

@Seanom it looks like that we finally solved this problem with #1397, I cannot reproduce the problem any more with the newest pattern lab version 5.16.1

wesleyboar · 2022-02-03T18:46:50Z

I also cannot reproduce the issue since v5.16.1. (I could reproduce it with an earlier version—I forgot which.)

Details

I am using Pattern Lab Node v5.16.1 on Mac Monterey, with Node v17.4.0, using a Vanilla Edition.

Seanom changed the title ~~Using Yarn to install dependencies~~ Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) Nov 2, 2018

bmuenzenmeyer added help wanted 🆘 good first issue 🎓 labels Nov 2, 2018

stale bot added the needs response 🤙 label Jan 1, 2019

stale bot closed this as completed Jan 19, 2019

engelfrost reopened this Jan 21, 2019

stale bot removed the needs response 🤙 label Jan 21, 2019

stale bot added the needs response 🤙 label May 28, 2019

stale bot removed the needs response 🤙 label May 28, 2019

stale bot added needs response 🤙 and removed needs response 🤙 labels Jul 27, 2019

stale bot added the needs response 🤙 label Sep 25, 2019

stale bot removed the needs response 🤙 label Sep 25, 2019

MaximDevoir mentioned this issue Oct 28, 2019

Autocomplete bug with yarn run zsh-users/zsh-completions#662

Closed

stale bot added the needs response 🤙 label Nov 24, 2019

stale bot closed this as completed Dec 24, 2019

JosefBredereck reopened this May 17, 2021

stale bot removed the needs response 🤙 label May 17, 2021

mfranzke mentioned this issue Dec 25, 2021

refactor(cli): correct the line endings before publishing #1397

Merged

stale bot added the needs response 🤙 label Jan 9, 2022

stale bot removed the needs response 🤙 label Jan 30, 2022

mfranzke added the needs response 🤙 label Feb 3, 2022

stale bot removed the needs response 🤙 label Feb 3, 2022

mfranzke closed this as completed Feb 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) #967

Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) #967

Seanom commented Oct 31, 2018

DanielRuf commented Nov 2, 2018 •

edited

Loading

stale bot commented Jan 1, 2019

stale bot commented Jan 19, 2019

DanielRuf commented Jan 19, 2019

jp-sauve commented Feb 9, 2019

DanielRuf commented Feb 9, 2019

zachariab commented Mar 27, 2019

zachariab commented Mar 29, 2019 •

edited

Loading

stale bot commented May 28, 2019

DanielRuf commented May 28, 2019

stale bot commented Jul 27, 2019

stale bot commented Sep 25, 2019

DanielRuf commented Sep 25, 2019

stale bot commented Nov 24, 2019

stale bot commented Dec 24, 2019

bradjones1 commented Apr 19, 2021

roman-sitewits commented May 17, 2021

theLine commented Sep 21, 2021 •

edited

Loading

stale bot commented Jan 9, 2022

mfranzke commented Jan 30, 2022

wesleyboar commented Feb 3, 2022 •

edited

Loading

Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) #967

Using Yarn to install dependencies on Mac results in file encoding issues (CRLF) #967

Comments

Seanom commented Oct 31, 2018

Expected Behavior

Actual Behavior

Steps to Reproduce

DanielRuf commented Nov 2, 2018 • edited Loading

stale bot commented Jan 1, 2019

stale bot commented Jan 19, 2019

DanielRuf commented Jan 19, 2019

jp-sauve commented Feb 9, 2019

DanielRuf commented Feb 9, 2019

zachariab commented Mar 27, 2019

zachariab commented Mar 29, 2019 • edited Loading

stale bot commented May 28, 2019

DanielRuf commented May 28, 2019

stale bot commented Jul 27, 2019

stale bot commented Sep 25, 2019

DanielRuf commented Sep 25, 2019

stale bot commented Nov 24, 2019

stale bot commented Dec 24, 2019

bradjones1 commented Apr 19, 2021

roman-sitewits commented May 17, 2021

theLine commented Sep 21, 2021 • edited Loading

stale bot commented Jan 9, 2022

mfranzke commented Jan 30, 2022

wesleyboar commented Feb 3, 2022 • edited Loading

DanielRuf commented Nov 2, 2018 •

edited

Loading

zachariab commented Mar 29, 2019 •

edited

Loading

theLine commented Sep 21, 2021 •

edited

Loading

wesleyboar commented Feb 3, 2022 •

edited

Loading