-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ie11): add ie11 to build #1876
Conversation
Deploy preview for pf-next ready! Built with commit 4d74198 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually just realized I hadn't built patternfly yet, which I suppose others may also do when developing locally. Could we add something like the following to if (files.length === 0) {
throw new Error(`getStylesheetPaths didn't receive any stylesheets to parse`);
} |
It would also probably also be a good time to fix the copy/pasta in the doc, and use something like |
So the main problem I see now is that when an instance of What I'd think to do here is first produce the problematic file and after that throw the error. This way users can search the resulting file to get a clue as to what went wrong. Also, we probably want to handle the error better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Use existing conversion utilities to write
patternfly-ie.css
which contains all components + base styles.Closes patternfly/patternfly-react#2092