Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ie11): add ie11 to build #1876

Merged
merged 5 commits into from
Jun 5, 2019
Merged

feat(ie11): add ie11 to build #1876

merged 5 commits into from
Jun 5, 2019

Conversation

redallen
Copy link
Contributor

@redallen redallen commented May 31, 2019

Use existing conversion utilities to write patternfly-ie.css which contains all components + base styles.

Closes patternfly/patternfly-react#2092

@patternfly-build
Copy link

patternfly-build commented May 31, 2019

Deploy preview for pf-next ready!

Built with commit 4d74198

https://deploy-preview-1876--pf-next.netlify.com

Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the glob pattern isn't working. Locally I'm getting the following

Screen Shot 2019-06-04 at 1 07 30 PM

Is getStylesheetPaths returning a proper array for you? Looking into it..

@seanforyou23
Copy link
Collaborator

seanforyou23 commented Jun 4, 2019

Actually just realized I hadn't built patternfly yet, which I suppose others may also do when developing locally. Could we add something like the following to getStylesheetPaths? You could add it right before we work with the files.

if (files.length === 0) {
  throw new Error(`getStylesheetPaths didn't receive any stylesheets to parse`);
}

@seanforyou23
Copy link
Collaborator

It would also probably also be a good time to fix the copy/pasta in the doc, and use something like /Path/to/patternfly-next/dist/{components,layouts,utilities}/**/*.css instead.

@seanforyou23
Copy link
Collaborator

So the main problem I see now is that when an instance of undefined is encountered, the script doesn't inform the user of where. The resulting stylesheet just contains Error: Stylesheet contains undefined.

What I'd think to do here is first produce the problematic file and after that throw the error. This way users can search the resulting file to get a clue as to what went wrong.

Also, we probably want to handle the error better?

Screen Shot 2019-06-04 at 2 23 17 PM

Copy link
Collaborator

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dgutride dgutride merged commit aac3939 into patternfly:master Jun 5, 2019
@patternfly-build
Copy link

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants