Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): media query matches border #1881

Merged
merged 4 commits into from
Jun 6, 2019

Conversation

christiemolloy
Copy link
Member

@christiemolloy christiemolloy commented Jun 3, 2019

fix #1823

Fixes the table so that when the table breaks to grid form, the border width changes to 8px, and the border color matches the background color.

Screen Shot 2019-06-03 at 3 48 32 PM

@patternfly-build
Copy link

patternfly-build commented Jun 3, 2019

Deploy preview for pf-next ready!

Built with commit 257633a

https://deploy-preview-1881--pf-next.netlify.com

@mcoker
Copy link
Contributor

mcoker commented Jun 4, 2019

did you mean to commit the chart changes in 84fad8f?

@mcoker
Copy link
Contributor

mcoker commented Jun 4, 2019

Looks like we lost the bottom border on expandable table rows if it's the last thing in the table (expandable, compact expandable, compound expansion)

Screen Shot 2019-06-04 at 2 44 50 PM

@christiemolloy
Copy link
Member Author

Thanks so much for catching that @mcoker

Screen Shot 2019-06-05 at 10 07 02 AM

@mcoker mcoker merged commit 7aae2fa into patternfly:master Jun 6, 2019
@patternfly-build
Copy link

🎉 This PR is included in version 2.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants