Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aboutmodalbox): add word break to content #1902

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

christiemolloy
Copy link
Member

fix #1784

Longs strings of words now break in the content section in the About Modal.

Screen Shot 2019-06-06 at 10 46 49 AM

@patternfly-build
Copy link

patternfly-build commented Jun 6, 2019

Deploy preview for pf-next ready!

Built with commit 15e80f4

https://deploy-preview-1902--pf-next.netlify.com

@srambach
Copy link
Member

srambach commented Jun 6, 2019

LGTM!

@@ -188,6 +188,10 @@
overscroll-behavior: contain;
-webkit-overflow-scrolling: touch;

> * {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the > is redundant since word-break is inherited.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated @mcoker

@srambach srambach merged commit b223640 into patternfly:master Jun 7, 2019
@patternfly-build
Copy link

🎉 This PR is included in version 2.12.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants