Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of BG image #1936

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Reduce size of BG image #1936

merged 1 commit into from
Jun 19, 2019

Conversation

psav
Copy link
Contributor

@psav psav commented Jun 17, 2019

As this background should be covered up by content most of the time, a small reduction in quality yields a big reduction in filesize.

@psav psav changed the title Reduce size of BG Reduce size of BG image Jun 17, 2019
@patternfly-build
Copy link

patternfly-build commented Jun 17, 2019

Deploy preview for pf-next ready!

Built with commit 4423c64

https://deploy-preview-1936--pf-next.netlify.com

@mcoker
Copy link
Contributor

mcoker commented Jun 17, 2019

@psav this looks great, thanks! Would you mind also copying this file to src/patternfly/assets/images and overwrite the existing pfbg_2000.jpg file there, too?

@psav
Copy link
Contributor Author

psav commented Jun 19, 2019

Sure thing

@psav
Copy link
Contributor Author

psav commented Jun 19, 2019

I can also do another PR to do the same type of transformation to the smaller size images

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!!

@mcoker mcoker merged commit f6a73b0 into patternfly:master Jun 19, 2019
@mcoker
Copy link
Contributor

mcoker commented Jun 19, 2019

@psav that would be great, thanks!

@patternfly-build
Copy link

🎉 This PR is included in version 2.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants