Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume core updates: inline edit (Table) ( Follow up to issue) #10003

Closed
Tracked by #9413
tlabaj opened this issue Jan 16, 2024 · 4 comments
Closed
Tracked by #9413

Consume core updates: inline edit (Table) ( Follow up to issue) #10003

tlabaj opened this issue Jan 16, 2024 · 4 comments
Assignees

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 16, 2024

Follow up to core issue patternfly/patternfly#5736

@thatblindgeye
Copy link
Contributor

Comparing the deprecated editable rows table example in v6 to the core v6 inline editable table example, there may not really be any updates needed in React. Core is still using the deprecated Dropdown for the kebab toggle, and React is using the deprecated Select, which should be the only differences (aside maybe from icons).

@thatblindgeye
Copy link
Contributor

cc @mcoker @andrew-ronaldson for above comment

@mcoker
Copy link
Contributor

mcoker commented Feb 19, 2024

@thatblindgeye LGTM!

@thatblindgeye
Copy link
Contributor

Closing per agreements above (Andrew left thumbs up emoji on my comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants