Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Investigate effort to pull the Virtual table into component library #4322

Closed
tlabaj opened this issue Jun 3, 2020 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jun 3, 2020

Describe the issue. What is the expected and unexpected behavior?
The virtual table is currently an extension. It is being used by multiple teams and we would like to investigate the feasibility and effort of pulling this into our component library.

@tlabaj tlabaj added the Spike label Jun 3, 2020
@tlabaj tlabaj modified the milestones: 2020.08, 2020.07 Jun 3, 2020
@kmcfaul
Copy link
Contributor

kmcfaul commented Jun 18, 2020

I would say it's a moderate to heavy lift to bring in the extension.

The extension is partially a fork, partially a re-export of react-virtualized, which has a lot of open issues that could potentially come up later down the line if we fully integrate the extension. The other potential hurdle would be making sure the extension is accessible, however looking back at Patrick's initial PR it appears he put some thought into this already when bringing it in. It would still require an audit though.

@tlabaj
Copy link
Contributor Author

tlabaj commented Jul 8, 2020

Investigation was completed and new issues #4453, #4454 and #4457 have been opened for follow up work.

@tlabaj tlabaj closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants