Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume core updates: Tooltip #9861

Closed
Tracked by #9860
tlabaj opened this issue Dec 6, 2023 · 3 comments
Closed
Tracked by #9860

Consume core updates: Tooltip #9861

tlabaj opened this issue Dec 6, 2023 · 3 comments
Assignees
@thatblindgeye
Milestone
2023.Q4

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Dec 6, 2023 •
edited
Loading

Follow up to core PR patternfly/patternfly#6064
@tlabaj tlabaj mentioned this issue Dec 6, 2023
Closed
@tlabaj tlabaj added PF6 labels Dec 6, 2023
@tlabaj tlabaj added this to the 2023.Q4 milestone Dec 6, 2023
@thatblindgeye
Copy link
Contributor

Comparing alpha 34 release to core v6 staging, it doesn't look like any updates are needed. React Tooltip is using the maxwidth var value in code, but that wasn't update in Core. cc @mcoker @andrew-ronaldson @lboehling for confirmation whether the following React screenshots look good to you compared to core's v6 tooltip

Basic v6 React tooltip

v6 React Tooltip aligned left of trigger

v6 React Tooltip aligned bottom-start

v6 React Tooltip in dark mode

@andrew-ronaldson
Copy link
Collaborator

I think this is good to go. Happy to close this out if you feel good @thatblindgeye

@thatblindgeye
Copy link
Contributor

Closing per above comments/agreements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

No branches or pull requests
3 participants
@andrew-ronaldson @tlabaj @thatblindgeye