Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume core Penta updates: Data list #9925

Closed
Tracked by #9924
tlabaj opened this issue Jan 2, 2024 · 6 comments
Closed
Tracked by #9924

Consume core Penta updates: Data list #9925

tlabaj opened this issue Jan 2, 2024 · 6 comments
Assignees

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 2, 2024

Follow up to core issue patternfly/patternfly#6106

@kmcfaul
Copy link
Contributor

kmcfaul commented Jan 16, 2024

DataList itself looks like no updates are required. The only discrepancy between v6 react and core is that the menu toggles are different. Core is using a pf-v5-c-dropdown__toggle pf-m-plain toggle while react uses pf-v5-c-menu-toggle pf-m-plain which has a rounded border.

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 20, 2024

menu toggle style updates are in and look good, react changes are still unneeded. The issue with the core side using dropdown-toggle is tracked patternfly/patternfly#6207

@kmcfaul kmcfaul closed this as completed Feb 20, 2024
@kmcfaul kmcfaul reopened this Feb 20, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 20, 2024

@patternfly/design-reviewers
@patternfly/core-in-react-reviewers

Could we get design+core eyes to ensure DataList looks good on the react side?

@andrew-ronaldson
Copy link
Collaborator

looks good as is!
Thanks for checking

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 28, 2024

Just need core once-over @patternfly/core-in-react-reviewers

@mcoker
Copy link
Contributor

mcoker commented Feb 28, 2024

LGTM! I noted one small update we'll want to make in a separate issue - #10119

@kmcfaul kmcfaul closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants