Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtpPacketizationConfig not properly initialized #1216

Closed
fusionfoxy opened this issue Jun 20, 2024 · 2 comments · Fixed by #1217
Closed

RtpPacketizationConfig not properly initialized #1216

fusionfoxy opened this issue Jun 20, 2024 · 2 comments · Fixed by #1217

Comments

@fusionfoxy
Copy link
Contributor

The RtpPacketizer takes a RtpPacketizationConfig when created. After creation, this config must have the playoutDelayId initialized manually eg.:

        auto rtpConf_ = std::make_shared<rtc::RtpPacketizationConfig>(42, "foo", 96, 90000);
        rtpConf_->playoutDelayId = 0;

Otherwise, valgrind will complain about a Conditional jump or move depends on uninitialised value at

==48363==    at 0x312384: rtc::RtpPacketizer::packetize(std::shared_ptr<std::vector<std::byte, std::allocator<std::byte> > >, bool) (rtppacketizer.cpp:34)

I would expect the config class to initialize this value automatically.

@paullouisageneau
Copy link
Owner

paullouisageneau commented Jun 20, 2024

Related to #1152

I'll push a fix.

@paullouisageneau
Copy link
Owner

Thank you for reporting, it is fixed by #1217. The fix will be released in v0.21.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants