Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No changes detected in port overrides when port number isn't changing. #121

Closed
wolf-cosmose opened this issue Mar 22, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@wolf-cosmose
Copy link
Contributor

I suspect this is because of the new port override hashing method.

I have for example:

  port_override {
    number          = 6
    name            = "office switch"
    port_profile_id = data.unifi_port_profile.builtin["office"].id
  }

If I change the port name or profile ID and run terraform plan, it says "No changes. Infrastructure is up-to-date."

I need to add another port_override or change some port_override's number for it to detect any changes,
and even then it will say it's deleting the whole port_override section and adding a new one,
instead of updating in-place.

@paultyng
Copy link
Owner

This is probably related to my set logic customization, sorry about that, let me just restore it to the default behavior and see how that goes.

@paultyng paultyng added the bug Something isn't working label Mar 22, 2021
@paultyng
Copy link
Owner

It would be a lot easier once rich maps are supported in the SDK, but not there yet.

@paultyng
Copy link
Owner

Just linking this for future reference: hashicorp/terraform-plugin-sdk#62

@paultyng
Copy link
Owner

Just kicked off the release for 0.24.2. The diff looks weird (a bunch of adds and removes of port overrides, just for like a name change), but its at least working for now.

@paultyng
Copy link
Owner

Fixed in 4b07869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants