Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: prefixing breaks keyframes #7

Closed
inakianduaga opened this issue Mar 14, 2016 · 3 comments · Fixed by #8
Closed

Bug: prefixing breaks keyframes #7

inakianduaga opened this issue Mar 14, 2016 · 3 comments · Fixed by #8

Comments

@inakianduaga
Copy link

Haven't checked this deeply but on first look it seems that the prefixing breaks keyframe definitions, for example, for a prefix _R,

@keyframes mdl-spinner__layer-4-fade-in-out {
  from {
    opacity: 0; }
  65% {
    opacity: 0; }
  75% {
    opacity: 0.99; }
  90% {
    opacity: 0.99; }
  100% {
    opacity: 0; } 
}
@-webkit-keyframes mdl-spinner__layer-4-fade-in-out {
  ._R 0%,
  ._R 65%{
     opacity:0
   }
   ._R 75%,
   ._R 90% {
      opacity:.99
   }
   ._R to{
     opacity:0
   }
}

which breaks the keyframe definition.

Basically prefixing shouldn't be applied at all on keyframe definitions? (since the actual rule that uses them will be prefixed anyways)

@pazams
Copy link
Owner

pazams commented Mar 14, 2016

Thanks for reporting!
I'll examine this by this weekend and report back.

@pazams pazams mentioned this issue Mar 30, 2016
@pazams pazams closed this as completed in #8 Mar 30, 2016
@pazams
Copy link
Owner

pazams commented Mar 30, 2016

fixed in version 0.1.7 on npm
@inakianduaga, please update the package and check it out
thanks!

@inakianduaga
Copy link
Author

@pazams Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants