Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all damage and death events into single class #127

Open
BrokenKage opened this issue Aug 10, 2020 · 0 comments
Open

Consolidate all damage and death events into single class #127

BrokenKage opened this issue Aug 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@BrokenKage
Copy link
Member

Currently have death and entity damage events scattered. If we are using these events to calculate critical hits, parries, etc. We must have a consistent class that handles this. This is important in region protections because a critical hit from our calculations could slip through and kill a player while the normal damage is not enough to kill.

@BrokenKage BrokenKage added the enhancement New feature or request label Aug 10, 2020
@BrokenKage BrokenKage self-assigned this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant