fix: declare argtypes for non-variadic arguments #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm interested in this fix as well. Are there additional things that need to be updated to support querying image data, as noted in #178 (comment)? |
|
Unfortunately, this fix is a problematic per the comment in the code: "GetField and SetField arguments are dependent on the tag", see also http://libtiff.maptools.org/man/TIFFGetField.3tiff.html that illustrates this dependency. Considering the capabilities of ctypes, I think we cannot interface libtiff GetField functionality within pylibtiff in a platform independent way, or at least it would require a considerable effort to make it function correctly. The same functionality could be implemented by using TIFFVGetField but that requires using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178
This declares the non-variadic arguments for SetField and GetField, which is needed on ARM64 due to ABI differences (see issue #178 for discussion). This should not impact compatibility with other architectures.