Use unique placeholders for each match #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhnns Any chance of getting this merged? |
einfallstoll
approved these changes
May 5, 2020
|
Sorry for the late response. I'm going to go ahead an merge this as I didn't see any issues and it seems to be a requested thing. Thank you for the contribution :) Released in 3.2.0 |
jannikkeye
pushed a commit
that referenced
this pull request
May 26, 2020
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2020
# [5.1.0](v5.0.1...v5.1.0) (2020-05-26) ### Features * unique placeholders for each match ([#83](#83)) ([5e61f0c](5e61f0c))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54 #57 #80 by generating a new placeholder for each dependency, rather than using a single one for the entire module.
The
undefinedissue was caused by the module cache returning the previously generated placeholder, but not adding tonewDependencies. Hence a mismatch between number ofnewDependenciesandextractedDependencyContentappeared, causingundefinedto be returned once we ran out ofnewDependencies. By using unique placeholders, this is no longer an issue.