Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate - 1st ave, manhattan #12

Open
missinglink opened this issue Oct 17, 2016 · 5 comments
Open

investigate - 1st ave, manhattan #12

missinglink opened this issue Oct 17, 2016 · 5 comments
Assignees
Milestone

Comments

@missinglink
Copy link
Member

missinglink commented Oct 17, 2016

there appear to be roads where there are no road (polylines do not match base map)

1st avenue, manhattan

1st_ave

@missinglink missinglink changed the title investigate investigate - 1st ave, manhattan Oct 19, 2016
@missinglink
Copy link
Member Author

need to discuss with @kevinkreiser

added to list of data issues to discuss here: https://github.com/valhalla/tools/issues/96

@missinglink
Copy link
Member Author

missinglink commented Oct 24, 2016

more recent screenshot, showing all the lines and which line each point is projecting on to (finds the closest).

it appears that the highway:footway are being used for interpolation.

ss

@missinglink
Copy link
Member Author

missinglink commented Oct 24, 2016

another similar issue for bus stop (top right):

http://www.openstreetmap.org/way/384288970

ss

@kevinkreiser
Copy link

for the bus issue above we end up keeping that little Bahnsteig because it has bus=yes which makes us assume that buses can drive on it and therefore its routable. turns out this makes no sense in this case because it also has: public_transport=platform which really means its a place for people to stand/sit and catch the bus not a way on which buses drive. @gknisely maybe we should change it to be pedestrian?

looking at taginfo it seems to show that bus=yes on a way is very rare: https://taginfo.openstreetmap.org/tags/bus=yes

maybe we shouldnt assume anything about access unless its access=bus for example. i cant find any docs that say motorcar=yes is about access on a way, i mean its even more rare than bus! https://taginfo.openstreetmap.org/tags/motorcar=yes

anyway even if we do change this, we might still one day get it into the data as routable by pedestrians if we start processing the public_transport=platform tag value combo.

the unfortunate thing is that the way has the same name as the street since thats the name of the stop. but why did they need to name the way. they named the one bus_stop node already. im not sure if we should say the data is wrong or if we should plan to work around this. i think if we do the revision about assuming access as mentioned above it should be fixed.

@gknisely
Copy link

I say we should toss...let me know if i should add the logic.

if (kv["public_transport"] and bus[kv["bus"]]=="true" and kv["highway"]==nil) then
return 1
end

@dianashk dianashk added this to the Interpolation milestone Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants