Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Cross-domain Att #25

Open
Ysz2022 opened this issue Jun 23, 2024 · 4 comments
Open

Question about Cross-domain Att #25

Ysz2022 opened this issue Jun 23, 2024 · 4 comments

Comments

@Ysz2022
Copy link

Ysz2022 commented Jun 23, 2024

image As shown in the appendix of the paper, it is said that attention contains: self-cross-domain att, row att, and cross-domain att. However, when I read the code, it seems that Only self-cross-domain att and row att are used, cross-domain att is discarded. Related details are as: image Does Era3D actually only uses the self-cross-domain att and row att?
@pengHTYX
Copy link
Owner

Oh, this is a typo. Attention block in Era3D contains self-cross-domain att, row-wise MV att, and customer cross att. I will clarify this in the appendix.

@Ysz2022
Copy link
Author

Ysz2022 commented Jun 24, 2024

Could you please tell me the where is the "customer cross att" in the code? In which line of which file? Thank you very much !!!!

@Ysz2022
Copy link
Author

Ysz2022 commented Jun 27, 2024

I have another 2 questions:
1、I completely agree with your row-wise attention. But for the self-cross-domain att, why you still compute the dense att instead of using the row-wise calculation?
2、For the customer cross att, it seems that this is a traditional cross-attention operation from the 'diffusers' repository, have you ever done any special designs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants