Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: 🐣 mock consensus engine can perform an app handshake #3754

Closed
cratelyn opened this issue Feb 6, 2024 · 3 comments
Closed

tests: 🐣 mock consensus engine can perform an app handshake #3754

cratelyn opened this issue Feb 6, 2024 · 3 comments
Labels
A-mock-consensus Area: Relates to the mock consensus engine A-testing Area: Relates to testing of Penumbra

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Feb 6, 2024 •
edited
Loading

stub issue.

see #3588.

https://github.com/cometbft/cometbft/blob/main/spec/abci/abci++_comet_expected_behavior.md

we should implement functionality such that the mock consensus engine can bootstrap itself. it should be able to perform a handshake with the app, which will involve implementing the info and init-chain parts of ABCI.
@cratelyn cratelyn added the A-testing Area: Relates to testing of Penumbra label Feb 6, 2024
This was referenced Feb 6, 2024
Closed
Closed
@hdevalence
Copy link
Member

I'm not sure this is important, the mock consensus engine and the app state will never be out of sync since they'll be in the same test function.

@cratelyn
Copy link
Contributor Author

cratelyn commented Feb 7, 2024

notes from call today:

  • we won't need info, at least initially

@cratelyn
Copy link
Contributor Author

cratelyn commented Feb 8, 2024

closing in favor of #3787.

@cratelyn cratelyn closed this as completed Feb 8, 2024
@cratelyn cratelyn reopened this Feb 8, 2024
@cratelyn cratelyn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mock-consensus Area: Relates to the mock consensus engine A-testing Area: Relates to testing of Penumbra
Projects
Penumbra
Archived in project
Testnets
Status: Future
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hdevalence @cratelyn