Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb #2

Open
dvv opened this issue Apr 30, 2010 · 0 comments
Open

mongodb #2

dvv opened this issue Apr 30, 2010 · 0 comments

Comments

@dvv
Copy link
Contributor

dvv commented Apr 30, 2010

Please, consider http://gist.github.com/383784
(10:24:30 PM) Vladimir: deanlandolt pointed out the difference between start()/end() which is used to instruct the store backend to return partial data, and slice(), which just narrows the result set already fetched from the backend
(10:26:28 PM) Vladimir: we should always fetch totalCount, regardless of directives.start/end being specified, or the whole if(totalCountPromise){... branch is missed, leading to incorrect results
(10:27:29 PM) Vladimir: pintura should wait until responseValue promise fulfilled, or we never get totalCount and never report correct Content-Range:
(10:30:06 PM) Vladimir: pintura should not guess of how much data store.query() provides, it should just rely on metadata.start/end which, in turn, can be mangled by the store. That way the consistency keeps: when we set Range: items=1-2 for GET /Obj/?start(3)&end(6), the store reports obj[3:6] and not obj[1:2](10:30:25 PM) Vladimir: All these fixed in the gist
(10:30:26 PM) Vladimir: TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant