Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vroom 1.12.0 #34

Closed
22 tasks done
krashish8 opened this issue Jun 1, 2022 · 1 comment · Fixed by #35
Closed
22 tasks done

Add support for Vroom 1.12.0 #34

krashish8 opened this issue Jun 1, 2022 · 1 comment · Fixed by #35
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@krashish8
Copy link
Member

krashish8 commented Jun 1, 2022

From Vroom v1.12.0 release notes: https://github.com/VROOM-Project/vroom/releases/tag/v1.12.0

Not considering backward compatibility at this stage of the project.

Crossing out the entries that require no change, or can be done in the future

Added

  • IntraTwoOpt local search operator (#706) internal
  • description key for unassigned tasks in output, if provided (#403) changes in json output, not cpp code
  • location_index key for unassigned tasks and each step, if provided (#625) changes in json output, not cpp code
  • Shared target to makefile, for creating Position Independent Code (#617)
  • Exposing some internals for Python through compile flags (#640) only for python
  • Stats on local search operators use for dev/debug purposes (#658) internal, for debugging
  • Project can be compiled without routing support to limit dependencies (#676)
  • Internal max_tasks constraints derived from input to speed up local-search (#648) internal

Changed

  • Prune local search moves based on TW constraints (#583) internal
  • Prune local search moves based on capacity constraints (#709) internal
  • Refactor exception class (#639) internal change, nothing needed on our end
  • CI builds now run against libosrm v5.26.0 (#651) CI changes
  • Reduce computing time on PDPTW benchmarks by around 20% (#559) internal
  • Change Input and parser signature to simplify downstream usage (#665): Made changes according to new Input signature
  • Consider move options in SWAP* that were previously wrongly discarded (#682) internal
  • Use cxxopts as command line parser instead of getopt (#602) internal
  • Change polylineencoder usage to submodule instead of plain header (#686) internal

Fixed

  • Remove duplicate definition of LocalSearch (#638) internal
  • Move priority check to Job constructor instead of input parser (#628) internal
  • Wrong index values without custom matrix (#683) internal
  • Assignments instead of equality checks in some plan mode assertions (#701) internal
  • Initialization of single-entry matrix (#699) internal
@krashish8 krashish8 self-assigned this Jun 1, 2022
@krashish8 krashish8 added this to the Release 0.4.0 milestone Jun 1, 2022
@krashish8 krashish8 added the enhancement New feature or request label Jun 1, 2022
@krashish8
Copy link
Member Author

Only three changes were needed, others were internal/optimization changes not affecting us:

  • Shared target to makefile, for creating Position Independent Code (#617): Needed to change the CI accordingly.
  • Project can be compiled without routing support to limit dependencies (#676): Needed to change the CI accordingly.
  • Change Input and parser signature to simplify downstream usage (#665): Made changes according to new Input signature.

@krashish8 krashish8 linked a pull request Jun 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant