Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure WebApp - Change localization files? #1439

Closed
2 tasks done
Manu-H opened this issue Sep 15, 2023 · 5 comments
Closed
2 tasks done

Azure WebApp - Change localization files? #1439

Manu-H opened this issue Sep 15, 2023 · 5 comments
Labels
question self-hosted Applies to self-hosted instances

Comments

@Manu-H
Copy link

Manu-H commented Sep 15, 2023

Checklist

❓ Question

Hello! :)
I deployed PasswordPusher to an Azure WebApp Service (issue #277).
Everything works fine. Branding, Config with environment variables and so on.
I can change the default language with the environment variables with an issue. There is one thing i'd like to change left - some text from the localization files. I can not find the files within the Azure App Services.
Does anyone have an similar setup and achieved this?

Thanks for your input! :)

📎 Additional context

@github-actions
Copy link

Hello @Manu-H, thanks for contributing to the Password Pusher community! We will respond as soon as possible.

@pglombardo
Copy link
Owner

Hi @Manu-H - it's not currently possible to change many of the strings (easily). The English strings are in the source code and their language translations are in config/locales.

You could rewrite those files and overlay new versions but that wouldn't affect English language strings.

The problem is that I could make some of the strings configurable, but then they would have no other language translations.

Which strings did you want to change?

@chesterbeckett
Copy link

chesterbeckett commented Oct 3, 2023

Checklist

❓ Question

Hello! :) I deployed PasswordPusher to an Azure WebApp Service (issue #277). Everything works fine. Branding, Config with environment variables and so on. I can change the default language with the environment variables with an issue. There is one thing i'd like to change left - some text from the localization files. I can not find the files within the Azure App Services. Does anyone have an similar setup and achieved this?

Thanks for your input! :)

📎 Additional context

Hi Manu-H,

I have deployed to Azure Web App too, via the screenshot methods noted in #277. Just wondered if you did anything differently as I cannot get the config changes to apply, using the environment variables (Application settings?).

Currently trying simple stuff like PWP_DEFAULT_LOCALE and PWP__BRAND__TAGLINE variables, but they are not taking even after a web app restart.

EDIT: PWP__BRAND__TAGLINE is working now but themes are not working at all.

if I use PWP__THEME setting, with value "cerulean", the theme remains default change, If I add the PWP_PRECOMPILE=true setting the container doesn't start at all.

https://github.com/pglombardo/PasswordPusher/blob/master/Configuration.md#configuring-a-theme

EDIT 2: Working now, no other reason than, just wait longer! Seems to take longer to create the containers with the precompile, but its still very hit n miss!

@pglombardo
Copy link
Owner

EDIT 2: Working now, no other reason than, just wait longer! Seems to take longer to create the containers with the precompile, but its still very hit n miss!

That's good to hear that it's working now. Setting PWP_PRECOMPILE does cause all of the assets to be re-compiled for the new theme on container boot which can take 30-90 seconds (depending on the system). I should probably add that to the documentation.

Is everything else working for you now @chesterbeckett?

@pglombardo
Copy link
Owner

Hi @Manu-H - I'll close out this issue soon if nothing remains.

I will get to moving all the strings out to independent yaml files eventually but no ETA yet.

Let me know if you need anything else.

@pglombardo pglombardo added the self-hosted Applies to self-hosted instances label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question self-hosted Applies to self-hosted instances
Projects
None yet
Development

No branches or pull requests

3 participants