Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and publicize Docker support #78

Closed
4 tasks done
pglombardo opened this issue Apr 13, 2018 · 7 comments
Closed
4 tasks done

Validate and publicize Docker support #78

pglombardo opened this issue Apr 13, 2018 · 7 comments

Comments

@pglombardo
Copy link
Owner

pglombardo commented Apr 13, 2018

https://hub.docker.com/r/pglombardo/passwordpusher/
https://github.com/pglombardo/PasswordPusher/blob/pwpush.com/Dockerfile

Add documentation adding/explaining:

  • Docker
  • Kubernetes
  • Openshift
  • Add pointers to docker hub of other images
@alexeygolikov
Copy link

alexeygolikov commented Apr 13, 2018

What about this?

# To use as temporary preview of the app.  Not suitable for production
# as the database is recreated from scratch on each docker image boot.

It would be great to see volume support for docker image.

@pglombardo
Copy link
Owner Author

Agree - I'll make sure this works with volumes before releasing. I think I originally put that Dockerfile together on a whim to test something. 👍

@christag
Copy link

Do you have a branch you're currently testing any improvements for Docker on that I can contribute to?

I'd like to help on this but I'm a beginner on docker/ruby/git/etc and I don't want to mess up your awesome app!

@pglombardo
Copy link
Owner Author

Hi @christag - you won't mess it up - feel free to make any pull-requests. They are a big help as I juggle my free time working on this. Let me try to resurrect my docker tests and I'll post an update here soon on where pwpush is currently with docker.

@sfarosu
Copy link
Contributor

sfarosu commented May 12, 2018

It's already with docker in the current stateless state (see pull request). We need to decide how we proceed further, ether add mysql support instead of sqlite3 or work towards placing sqlite data on persistent storage in Openshift/Kubernetes.

Image here: https://hub.docker.com/r/sfarosu/passwordpusher-ephemeral/

@pglombardo
Copy link
Owner Author

Merged #81 with an updated Dockerfile. Thanks @sfarosu

Added tasks to this issue to cover documentation.

@pglombardo
Copy link
Owner Author

Just merged #82 and updated the front page README as a first pass. I suspect I'll update documentation more as time passes but for now we clearly point out the new container support.

If either of you see any issues, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants