InWhere EOF exception

[traikodinev]

$users = \Models\Users::query()
    ->inWhere("id", array())
    ->execute();

When inWhere is given an empty array, it crashes with the following exception:

Phalcon\Mvc\Model\Exception: Syntax error, unexpected EOF

At the very least, the error could make more sense :)

[andresgutierrez]

"id" is not an expression that can be evaluated (it requires an operator) so it encounters the EOF which is unexpected for the parser, so a syntax error is thrown, totally make sense

[traikodinev]

But it's not a syntax error.. Unexpected EOF has a completely different meaning.
It might make sense when you know how it works, but the exception is totally wrong.

[andrew-demb]

I'm sorry for up closed issue, but I have a question.
Why in \Phalcon\Mvc\Model\Criteria::inWhere() (

cphalcon/phalcon/mvc/model/criteria.zep

Line 448 in cf3c1fe

for value in values {

) we don't check for empty array values and modify condition like the \Phalcon\Mvc\Model\Query\Builder::inWhere() (

cphalcon/phalcon/mvc/model/query/builder.zep

Line 752 in cf3c1fe

if !count(values) {

)? I think it would have a bit more logic and resolve this issue.
Phalcon 2.1.x

[sergeyklay]

@andrew-demb Could you please create separated issue with script to reproduce

[sergeyklay]

Fixed in the 3.0.x branch.