Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Optimization + bug fixes #1093

Merged
merged 22 commits into from Aug 15, 2013
Merged

Cache Optimization + bug fixes #1093

merged 22 commits into from Aug 15, 2013

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2013

In brief:

  • before: 80,098 allocs, 80,073 frees, 50,238,672 bytes allocated
  • after: 79,686 allocs, 79,661 frees, 15,219,256 bytes allocated

Tested with

USE_ZEND_ALLOC=0 valgrind $(phpenv which php) unit-tests/manual-unit.php CacheTest.php CacheTest

Bug fixes:

  • 6c37bad: looks like it is not always safe to store zval** as references to properties in PHP 5.4+ (zval** points to the location where the property is stored and the properties sometimes migrate); this will probably fix the bug with crashing session bag
  • c46c766 implements Phalcon\Cache\Backend\Memory::queryKeys()
  • 00f2177 adds checks to phalcon_call_XXX to ensure that all arguments are zval*'s
  • e69c7ba fixes bugs in Libmemcached that crippled past the review

phalcon pushed a commit that referenced this pull request Aug 15, 2013
Cache Optimization + bug fixes
@phalcon phalcon merged commit 5193890 into phalcon:1.3.0 Aug 15, 2013
@phalcon
Copy link
Collaborator

phalcon commented Aug 15, 2013

Great!

@ghost ghost deleted the cache branch August 16, 2013 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants