Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Use recommended reason phrases for redirect #1175

Closed
oh-ren opened this issue Aug 29, 2013 · 2 comments
Closed

[NFR] Use recommended reason phrases for redirect #1175

oh-ren opened this issue Aug 29, 2013 · 2 comments

Comments

@oh-ren
Copy link

oh-ren commented Aug 29, 2013

Currently, when using a redirect, no matter what status code is used, the reason phrase 'Redirect' is used.

This is not erroneous, but wouldn't it be more elegant / in accordance with the rest of the web to use the recommended phrases as listed in RFC 2616?:

301 Moved Permanently
302 Found
303 See Other
304 Not Modified
...

Relevant link: http://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html

Cheers.

ps. is an issue like this considered to be a NFR?
The info over here: https://github.com/phalcon/cphalcon/blob/master/CONTRIBUTING.md does make me think so?
Could it be a good idea to make a distinction between suggestions (for improvement, like this one) and truly NEW feature requests?

@phalcon
Copy link
Collaborator

phalcon commented Sep 1, 2013

This is implemented in 1.3.0

@phalcon phalcon closed this as completed Sep 1, 2013
@oh-ren
Copy link
Author

oh-ren commented Nov 5, 2013

Just for the record: this is in 1.2.4 already :)

(Thx for implementing!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant