Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Phalcon\Tag\Select::selectField() #1339

Merged
merged 13 commits into from Oct 7, 2013
Merged

Fix bug in Phalcon\Tag\Select::selectField() #1339

merged 13 commits into from Oct 7, 2013

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2013

This PR:

  • fixes 'Array to string conversion' error in Phalcon\Tag\Select::selectField
  • adds several tests from unit-tests/ to php-tests/
  • adds support for local database configs to php-tests/
  • fixes several incorrect tests

phalcon pushed a commit that referenced this pull request Oct 7, 2013
Merge pull request #1339 from sjinks/tests
768111d 
Fix bug in Phalcon\Tag\Select::selectField()
@phalcon phalcon merged commit 768111d into phalcon:1.3.0 Oct 7, 2013
@ghost ghost deleted the tests branch October 8, 2013 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phalcon @sjinks