Phalcon\Flash\Session::has return true when messages array is empty

[yannux]

Hi,

Using Phalcon\Flash\Session::has() return true whereas the messages array is empty.

cphalcon/phalcon/Flash/Session.zep

Line 43 in a803581

public function has(type = null) -> bool

/**
     * Checks whether there are messages
     */
    public function has(type = null) -> bool
    {
        var messages;

        let messages = this->getSessionMessages(false);

        if typeof type != "string" {
            return true;
        }

        return isset messages[type];
    }

Sorry I don't understand why type != 'string return true,
but maybe it's possible to add something like :

if empty messages {
    return false;
}

Regards,

[niden]

Resolved in #15353