Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor setFileToSend() #832

Merged
merged 2 commits into from Jul 15, 2013
Merged

Honor setFileToSend() #832

merged 2 commits into from Jul 15, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2013

See #831

phalcon pushed a commit that referenced this pull request Jul 15, 2013
Merge pull request #832 from sjinks/issue-831
92246c2 
Honor setFileToSend()
@phalcon phalcon merged commit 92246c2 into phalcon:1.2.1 Jul 15, 2013
@dreamsxin
Copy link
Contributor

/home/wxservice/cphalcon/unit-tests/ResponseTest.php:202

FAILURES!
Tests: 8, Assertions: 13, Failures: 1.

@ghost ghost deleted the issue-831 branch July 16, 2013 03:58
@ghost
Copy link
Author

ghost commented Jul 16, 2013

@dreamsxin Please build the extension from ext/ not from build/

Line 202 is the test for setFileToSend(); it was fixed in ext but not in build

@dreamsxin
Copy link
Contributor

@sjinks Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamsxin @phalcon @sjinks